gtk4.git
9 years agowindow: Simplify _set_focus
Timm Bäder [Wed, 8 Feb 2017 13:25:30 +0000 (14:25 +0100)]
window: Simplify _set_focus

9 years agowindow: Remove _gtk_window_set_is_toplevel
Timm Bäder [Wed, 8 Feb 2017 13:13:23 +0000 (14:13 +0100)]
window: Remove _gtk_window_set_is_toplevel

All GtkWindow instances are toplevels.

9 years agowindow: Fold update_has_focus in to set_is_active
Timm Bäder [Wed, 8 Feb 2017 13:05:01 +0000 (14:05 +0100)]
window: Fold update_has_focus in to set_is_active

We're now only ever setting has_focus to the same value we set is_active
to, so also remove that field from the private struct.

9 years agowindow: Remove has-toplevel-focus property
Timm Bäder [Wed, 8 Feb 2017 12:55:11 +0000 (13:55 +0100)]
window: Remove has-toplevel-focus property

Since embedded toplevels don't exist anymore, :has-toplevel-focus is
equivalent to :active.

9 years agowindow: Remove check_resize special case for embedded toplevels
Timm Bäder [Wed, 8 Feb 2017 12:45:51 +0000 (13:45 +0100)]
window: Remove check_resize special case for embedded toplevels

Those don't exist anymore.

9 years agowindow: Remove gtk_quark_embedded
Timm Bäder [Wed, 8 Feb 2017 12:43:07 +0000 (13:43 +0100)]
window: Remove gtk_quark_embedded

Unused.

9 years agowidget: Emit ::focus regardless of container-ness and can-focus
Timm Bäder [Wed, 8 Feb 2017 12:35:23 +0000 (13:35 +0100)]
widget: Emit ::focus regardless of container-ness and can-focus

9 years agocontainer: Remove focus_child pointer
Timm Bäder [Wed, 8 Feb 2017 09:02:47 +0000 (10:02 +0100)]
container: Remove focus_child pointer

Use GtkWidget's instead.

9 years agowidget: Also reset focus on non-container widgets
Timm Bäder [Wed, 8 Feb 2017 08:26:40 +0000 (09:26 +0100)]
widget: Also reset focus on non-container widgets

9 years agoMake gtk_container_set_focus_child private
Timm Bäder [Wed, 8 Feb 2017 08:14:20 +0000 (09:14 +0100)]
Make gtk_container_set_focus_child private

9 years agoRemove gtk_container_get_focus_child
Timm Bäder [Wed, 8 Feb 2017 08:07:18 +0000 (09:07 +0100)]
Remove gtk_container_get_focus_child

9 years agowidget: Save pointer to focus child
Timm Bäder [Wed, 8 Feb 2017 08:00:29 +0000 (09:00 +0100)]
widget: Save pointer to focus child

Do the same thing GtkContainer does.

9 years agocssimageicontheme: Cache size + texture
Timm Bäder [Wed, 29 Mar 2017 17:26:18 +0000 (19:26 +0200)]
cssimageicontheme: Cache size + texture

9 years agoglrenderer: Reuse the GArray for render items
Timm Bäder [Wed, 29 Mar 2017 16:45:51 +0000 (18:45 +0200)]
glrenderer: Reuse the GArray for render items

9 years agoglrenderer: Add render items for child nodes
Timm Bäder [Fri, 6 Jan 2017 22:03:49 +0000 (23:03 +0100)]
glrenderer: Add render items for child nodes

9 years agoglrenderer: Handle color nodes
Timm Bäder [Fri, 6 Jan 2017 19:53:12 +0000 (20:53 +0100)]
glrenderer: Handle color nodes

9 years agoglrenderer: Store uniform locations per program
Timm Bäder [Fri, 6 Jan 2017 19:18:35 +0000 (20:18 +0100)]
glrenderer: Store uniform locations per program

9 years agowidget: Fix checks in gtk_widget_snapshot()
Timm Bäder [Sun, 26 Mar 2017 10:45:50 +0000 (12:45 +0200)]
widget: Fix checks in gtk_widget_snapshot()

If the widget isn't drawable anyway, just return;

If the widget needs an allocate, print a warning, since it indicates a
problem in the widget workflow (e.g. forgot to size_allocate a child
widget).

This maches the previous checks in gtk_widget_draw (with the same
problems).

9 years agofilechooserbutton: Hide the combobox by default
Timm Bäder [Sun, 26 Mar 2017 10:42:07 +0000 (12:42 +0200)]
filechooserbutton: Hide the combobox by default

9 years agorecentchooserwidget: Inherit from GtkWidget
Timm Bäder [Sat, 25 Mar 2017 20:19:44 +0000 (21:19 +0100)]
recentchooserwidget: Inherit from GtkWidget

9 years agoappchooserwidget: Inherit from GtkWidget
Timm Bäder [Sat, 25 Mar 2017 20:10:27 +0000 (21:10 +0100)]
appchooserwidget: Inherit from GtkWidget

9 years agofontchooserwidget: Inherit from GtkWidget
Timm Bäder [Sat, 25 Mar 2017 19:49:00 +0000 (20:49 +0100)]
fontchooserwidget: Inherit from GtkWidget

9 years agofontchooserwidget: Remove unused defines
Timm Bäder [Sat, 25 Mar 2017 19:43:28 +0000 (20:43 +0100)]
fontchooserwidget: Remove unused defines

9 years agofilechooserwidget: Inherit from GtkWidget
Timm Bäder [Sat, 25 Mar 2017 19:36:10 +0000 (20:36 +0100)]
filechooserwidget: Inherit from GtkWidget

9 years agoRemove the Raleigh theme
Timm Bäder [Sat, 25 Mar 2017 16:26:37 +0000 (17:26 +0100)]
Remove the Raleigh theme

It's been broken for ages.

9 years agowidget: Add a GtkBuildable::add_child implementation
Timm Bäder [Sat, 25 Mar 2017 16:17:40 +0000 (17:17 +0100)]
widget: Add a GtkBuildable::add_child implementation

Just call gtk_widget_set_parent in there.

9 years agoprogressbar: Remove unused defines
Timm Bäder [Sat, 25 Mar 2017 13:33:14 +0000 (14:33 +0100)]
progressbar: Remove unused defines

9 years agoflowbox: don’t select when rubberbanding over nothing
Ernestas Kulik [Thu, 30 Mar 2017 19:29:57 +0000 (22:29 +0300)]
flowbox: don’t select when rubberbanding over nothing

When rubberbanding over an empty area, everything is selected on gesture
end, which is a bit counter-intuitive.

https://bugzilla.gnome.org/show_bug.cgi?id=780735

9 years agoosx: fix build
Christoph Reiter [Tue, 14 Mar 2017 20:00:37 +0000 (21:00 +0100)]
osx: fix build

https://bugzilla.gnome.org/show_bug.cgi?id=734946

9 years agogdkwindow: subsurface in gdk_window_get_parent()
Olivier Fourdan [Wed, 1 Feb 2017 14:09:52 +0000 (15:09 +0100)]
gdkwindow: subsurface in gdk_window_get_parent()

When the GtkWidget hierarchy does not match the GdkWindow hierarchy, the
GtkWidget code may find a common ancestor that cannot be found while
traversing the GdkWindow tree using gdk_window_get_parent().

This happens with for example on Wayland, a GtkPopover has another
GtkPopover as parent, in this case, the GdkWindow parent is the root
window, whereas the GtkWidget parent is the other GtkPopover.

That confuses the gtk_widget_translate_coordinates() logic which will
bail out in this case and won't return the translated coordinates.

Make gdk_window_get_effective_parent() aware of subsurfaces and use the
transient_for which represents the actual parent (whereas the parent
might be pointing to the root window).

Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=774148

9 years agoWork around a wayland crash
Matthias Clasen [Thu, 30 Mar 2017 13:14:05 +0000 (09:14 -0400)]
Work around a wayland crash

For some reason, we are seeing damage being NULL here.
While that should never be the case, crashing on it is
unkind and makes the Wayland experience unusable.

9 years agoDocument GTK_INSPECTOR_RENDERER
Matthias Clasen [Thu, 30 Mar 2017 02:48:19 +0000 (22:48 -0400)]
Document GTK_INSPECTOR_RENDERER

Also add GTK_INSPECTOR_DISPLAY to the docs at the same time.

9 years agogtk_widget_intersect: fix annotations
Christoph Reiter [Thu, 30 Mar 2017 08:45:00 +0000 (10:45 +0200)]
gtk_widget_intersect: fix annotations

https://bugzilla.gnome.org/show_bug.cgi?id=773228

9 years agogskrendernodeimpl: Fix documentation argument type
Daniel Boles [Mon, 27 Mar 2017 21:13:32 +0000 (22:13 +0100)]
gskrendernodeimpl: Fix documentation argument type

9 years agoGSK: Fix a bunch of warnings from the GIR scanner
Daniel Boles [Mon, 27 Mar 2017 19:13:15 +0000 (20:13 +0100)]
GSK: Fix a bunch of warnings from the GIR scanner

arising from conflicting argument names, missing annotations, etc.

9 years agoTextView: Be const-correct when passing a pointer
Daniel Boles [Mon, 27 Mar 2017 18:14:38 +0000 (19:14 +0100)]
TextView: Be const-correct when passing a pointer

The TextIter is passed by pointer for efficiency. We neither need to
modify it, nor should we leave it possible to accidentally do so. So,
it should be passed as a pointer-to-const.

9 years agoTextView: Get line direction in more efficient way
Daniel Boles [Sun, 26 Mar 2017 14:53:12 +0000 (15:53 +0100)]
TextView: Get line direction in more efficient way

We do not need to go through the heavyweight process of constructing a
TextLineDisplay just to get the direction out of it, when we can simply
use TextIter API to get the text and then get its direction using Pango.

Adapted from a patch by Mehdi Sadeghi for GtkSourceView:

https://bugzilla.gnome.org/show_bug.cgi?id=779081#c20

9 years agoTextBuffer: Add missing transfer full annotations
Daniel Boles [Sun, 26 Mar 2017 14:50:57 +0000 (15:50 +0100)]
TextBuffer: Add missing transfer full annotations

9 years agoUpdate Polish translation
Piotr Drąg [Sat, 25 Mar 2017 22:17:18 +0000 (23:17 +0100)]
Update Polish translation

9 years agoprintjob: Clarify array ownership in gtk_print_job_set_page_ranges()
Kjell Ahlstedt [Fri, 24 Mar 2017 15:41:47 +0000 (16:41 +0100)]
printjob: Clarify array ownership in gtk_print_job_set_page_ranges()

Add a documentation annotation saying that set_page_ranges transfers
ownership of the GtkPageRange array.
Add a g_free() call to fix a memory leak when set_page_ranges is
used repeatedly.

https://bugzilla.gnome.org/show_bug.cgi?id=780234

9 years agoAvoid more compiler warnings
Matthias Clasen [Thu, 23 Mar 2017 16:15:26 +0000 (16:15 +0000)]
Avoid more compiler warnings

9 years agoAvoid unused variable warnings
Matthias Clasen [Thu, 23 Mar 2017 16:15:00 +0000 (16:15 +0000)]
Avoid unused variable warnings

9 years agoAvoid redefining GNU_SOURCE
Matthias Clasen [Thu, 23 Mar 2017 15:13:33 +0000 (15:13 +0000)]
Avoid redefining GNU_SOURCE

Gives a compiler warning with the wrong flags.

9 years agoAvoid some compiler warnings
Matthias Clasen [Thu, 23 Mar 2017 15:13:13 +0000 (15:13 +0000)]
Avoid some compiler warnings

9 years agoprinting: Don't hang in gtk_enumerate_printers()
Marek Kasik [Wed, 26 Mar 2014 11:29:46 +0000 (12:29 +0100)]
printing: Don't hang in gtk_enumerate_printers()

Stop enumerating printers when all backends were removed.

https://bugzilla.gnome.org/show_bug.cgi?id=686838

9 years agoUpdate Russian translation
Stas Solovey [Wed, 22 Mar 2017 21:46:35 +0000 (21:46 +0000)]
Update Russian translation

(cherry picked from commit a7f3fd12d5c4e866a1d8e05360a7052a756ee8bd)

9 years agomir: always emit a resize when creating windows
William Hua [Tue, 21 Mar 2017 15:25:36 +0000 (11:25 -0400)]
mir: always emit a resize when creating windows

9 years agoUpdate German translation
Flo H [Tue, 21 Mar 2017 18:38:39 +0000 (18:38 +0000)]
Update German translation

9 years agoglcontext: Fix buffer age comparison
Timm Bäder [Tue, 21 Mar 2017 18:03:27 +0000 (19:03 +0100)]
glcontext: Fix buffer age comparison

The old code had a dead >=3 branch, causing flickering.

9 years agogdkdragsource: Ensure button >= 1
Timm Bäder [Tue, 21 Mar 2017 15:06:13 +0000 (16:06 +0100)]
gdkdragsource: Ensure button >= 1

So the left shift later doesn't overflow.

9 years agowidget: Prepend style classes to list when parsing
Timm Bäder [Tue, 21 Mar 2017 13:40:21 +0000 (14:40 +0100)]
widget: Prepend style classes to list when parsing

Since the later gtk_style_context_add_class doesn't care about the order
of the style classes, we can as well just prepend style classes to the
list and avoid the squared behavior when appending to a linked list.

9 years agobuilderparser: Remove pointless TagType struct
Timm Bäder [Tue, 21 Mar 2017 10:15:03 +0000 (11:15 +0100)]
builderparser: Remove pointless TagType struct

9 years agoUpdate Indonesian translation
Andika Triwidada [Tue, 21 Mar 2017 12:50:54 +0000 (12:50 +0000)]
Update Indonesian translation

9 years agoScrollbar: grammar fix for previous commit
Daniel Boles [Tue, 21 Mar 2017 00:06:50 +0000 (00:06 +0000)]
Scrollbar: grammar fix for previous commit

9 years agoScrollbar: Tweak intro docs a bit
Daniel Boles [Mon, 20 Mar 2017 23:54:57 +0000 (23:54 +0000)]
Scrollbar: Tweak intro docs a bit

Explain where the adjustment comes from, clarify some of the wording
about how its fields influence the scrollbar, and also note that the
steppers may not be present, since they aren’t in our default themes.

9 years agoScrolledWindow: Don’t check if child is Scrollable
Daniel Boles [Fri, 10 Mar 2017 20:37:27 +0000 (20:37 +0000)]
ScrolledWindow: Don’t check if child is Scrollable

If the child added is not a Scrollable, it gets wrapped in a ViewPort –
which is. So it is impossible to end up with a non-Scrollable child.

Just check we have /any/ child where needed, which is semantically nicer

https://bugzilla.gnome.org/show_bug.cgi?id=778853

9 years agoScrolledWindow: Streamline/clarify the intro docs
Daniel Boles [Mon, 20 Mar 2017 23:20:26 +0000 (23:20 +0000)]
ScrolledWindow: Streamline/clarify the intro docs

 • intro: Clarify that external policy and/or adjustments can be used.
 • add(): Don’t waffle on about having to add a ViewPort since we handle
          that transparently for the user, so they can add() any widget.
 • Adjustment stuff: most of this was repeating the docs for Scrollbar,
                     so just refer the user to that. Also, mention how
                     policies NEVER and EXTERNAL interact with all this.

https://bugzilla.gnome.org/show_bug.cgi?id=778853

9 years agoTooltip: Avoid redundant variable initialisations
Daniel Boles [Mon, 20 Mar 2017 21:04:49 +0000 (21:04 +0000)]
Tooltip: Avoid redundant variable initialisations

has_tooltip_widget was assigned twice in immediate succession.

return_value is not used anywhere else in this function since commit
14a864c8b55dfe92f8957499f12a3f9303188a12 and does not need a default
value anymore, so move it to the inner scope and don't init to NULL.

9 years agoGdkWaylandWindow: Force window titles to valid utf8
Timm Bäder [Mon, 20 Mar 2017 18:56:22 +0000 (19:56 +0100)]
GdkWaylandWindow: Force window titles to valid utf8

Use the new g_utf8_make_valid in case the given title is not valid utf8.
Also bump the glib requirement to 2.51.5.

9 years agolabel: Properly calculate half the height
Timm Bäder [Mon, 20 Mar 2017 16:20:12 +0000 (17:20 +0100)]
label: Properly calculate half the height

Since we compare it to a double anyway, might as well divide by 2.0.

9 years agotooltip: Remove unused assignment
Timm Bäder [Mon, 20 Mar 2017 14:36:05 +0000 (15:36 +0100)]
tooltip: Remove unused assignment

hide_tooltip  gets overriden in any case 2 lines down, and return_value
isn't used later in that function. The second assignment was introduced
in ef1da5f6c2450fc5f7c7de4a17114cc7507a41ad, directly below the first
assignment.

9 years agocss-editor: Remove unused if statement
Timm Bäder [Mon, 20 Mar 2017 14:01:28 +0000 (15:01 +0100)]
css-editor: Remove unused if statement

The static local is set to NULL and never set to anything else, so we
never use it anyway.

9 years agowindow: Remove pointless ternary operator
Timm Bäder [Mon, 20 Mar 2017 13:59:14 +0000 (14:59 +0100)]
window: Remove pointless ternary operator

we're already checking for orientation == GTK_ORIENTATION_HORIZONTAL
right before this line, so just pass GTK_ORIENTATION_VERTICAL.

9 years agobox: Make sure center_req is initialized
Timm Bäder [Mon, 20 Mar 2017 13:16:56 +0000 (14:16 +0100)]
box: Make sure center_req is initialized

In case we have an invisible center widget, we never initialize it, but
later still use it.

9 years agoprogressbar: Remove useless if statement
Timm Bäder [Mon, 20 Mar 2017 08:22:13 +0000 (09:22 +0100)]
progressbar: Remove useless if statement

Both the if and the else block contained exactly the same code.

9 years agogsk: Take scale factor into account when setting up the gl scissor
Alexander Larsson [Mon, 20 Mar 2017 09:52:58 +0000 (10:52 +0100)]
gsk: Take scale factor into account when setting up the gl scissor

9 years agogl renderer: Fix hidpi fallback rendering
Alexander Larsson [Sun, 19 Mar 2017 18:24:50 +0000 (19:24 +0100)]
gl renderer: Fix hidpi fallback rendering

When allocating the surface, take scale into consideration.

9 years agoUpdate Friulian translation
Fabio Tomat [Sun, 19 Mar 2017 21:24:45 +0000 (21:24 +0000)]
Update Friulian translation

9 years agonotebook: Remove dead assignment
Timm Bäder [Sun, 19 Mar 2017 16:05:34 +0000 (17:05 +0100)]
notebook: Remove dead assignment

9 years agoGtkRecentManager: Remove superfluous local variable
Timm Bäder [Sun, 19 Mar 2017 13:28:32 +0000 (14:28 +0100)]
GtkRecentManager: Remove superfluous local variable

9 years agoGdkRenderer: Fix a compiler warning
Timm Bäder [Sun, 19 Mar 2017 13:26:02 +0000 (14:26 +0100)]
GdkRenderer: Fix a compiler warning

9 years agoGdkX11DeviceManager: Fix debugging output
Timm Bäder [Sun, 19 Mar 2017 13:24:54 +0000 (14:24 +0100)]
GdkX11DeviceManager: Fix debugging output

The 2 values added in 3.22 were missing from the source_names array.

9 years agoGdkMonitor: Use 1 as scale fallback value
Timm Bäder [Sun, 19 Mar 2017 13:24:02 +0000 (14:24 +0100)]
GdkMonitor: Use 1 as scale fallback value

The same value we use in gtk_widget_get_scale_factor.

9 years agocss-overview: Fix inconsistent British English use
Daniel Boles [Sat, 18 Mar 2017 12:29:28 +0000 (12:29 +0000)]
css-overview: Fix inconsistent British English use

9 years agovulkan: fix compilation
Tim-Philipp Müller [Sat, 18 Mar 2017 12:17:44 +0000 (12:17 +0000)]
vulkan: fix compilation

9 years agoentrycompletion: Remove unnecessary NULL check
Timm Bäder [Sat, 18 Mar 2017 06:13:13 +0000 (07:13 +0100)]
entrycompletion: Remove unnecessary NULL check

completion really shouldn't be NULL at this point, especially since it
gets dereferenced higher up in the function.

9 years agocalendar: Fix else branch indentations
Timm Bäder [Sat, 18 Mar 2017 06:06:35 +0000 (07:06 +0100)]
calendar: Fix else branch indentations

9 years agoGdkDrawingContext: Add missing break in switch statement
Timm Bäder [Fri, 17 Mar 2017 18:00:00 +0000 (19:00 +0100)]
GdkDrawingContext: Add missing break in switch statement

9 years agocss-overview: Fix+Explain color expr number ranges
Daniel Boles [Sat, 18 Mar 2017 01:13:42 +0000 (01:13 +0000)]
css-overview: Fix+Explain color expr number ranges

Last try, promise. They don’t all use 0 to 1. We should probably explain
the effects too. Hopefully this manages that while not being too verbose

9 years agoAvoid a critical warning in the filechooser portal
Matthias Clasen [Fri, 17 Mar 2017 23:56:33 +0000 (19:56 -0400)]
Avoid a critical warning in the filechooser portal

This was showing up when cancelling a portal file chooser
in recipes.

9 years agocss-overview: Elaborate how color expressions work
Daniel Boles [Fri, 17 Mar 2017 23:55:15 +0000 (23:55 +0000)]
css-overview: Elaborate how color expressions work

9 years agodocs/css-overview: Fix color functions’ arg orders
Daniel Boles [Fri, 17 Mar 2017 23:25:13 +0000 (23:25 +0000)]
docs/css-overview: Fix color functions’ arg orders

shade/alpha/mix() take colour(s) and a number that is the ratio by which
to transform them. It was written here that these shall be passed in the
order (number, colour). That was wrong: they must be passed in the order
(colour[s], number) to work, and for the Inspector not to flag an error.

9 years agoUpdate Latvian translation
Rūdolfs Mazurs [Fri, 17 Mar 2017 21:03:08 +0000 (23:03 +0200)]
Update Latvian translation

9 years agodocs: Remove mentions of gtk_init_with_args().
Murray Cumming [Fri, 17 Mar 2017 20:11:26 +0000 (21:11 +0100)]
docs: Remove mentions of gtk_init_with_args().

Because it has been removed: See commit 7e8eb3ddcd29ce9eecb14a56dbfeb0caf64dc772

9 years agoheaderbar: Fix size requisition variable mixup
Timm Bäder [Fri, 17 Mar 2017 17:49:52 +0000 (18:49 +0100)]
headerbar: Fix size requisition variable mixup

Happened when porting to gtk_widget_measure.

9 years agoGtkShaderBuilder Fix copy/paste error in precondition
Timm Bäder [Thu, 16 Mar 2017 18:16:24 +0000 (19:16 +0100)]
GtkShaderBuilder Fix copy/paste error in precondition

gtk_shader_builder_add_define should check both define_name and
define_value for not-NULL and not-empty, but the second precondition
check checks define_name again for not-empty-ness.

9 years agoAllow custom renderer for the inspector
Alexander Larsson [Fri, 17 Mar 2017 15:12:45 +0000 (16:12 +0100)]
Allow custom renderer for the inspector

If you set GTK_INSPECTOR_RENDERER to the same type of
values that GSK_RENDERER takes this can change the renderer
used for the inspector. This is useful if you're debugging
one renderer and don't want to affect the inspector.

9 years agoquartz: fix build for <10.12
Christoph Reiter [Tue, 14 Mar 2017 19:53:09 +0000 (20:53 +0100)]
quartz: fix build for <10.12

The style mask type was changed from NSUInteger to NSWindowStyleMask.
Use NSUInteger so it also works on older macOS.

https://bugzilla.gnome.org/show_bug.cgi?id=780019

9 years agoUpdate Russian translation
Stas Solovey [Tue, 14 Mar 2017 19:11:47 +0000 (19:11 +0000)]
Update Russian translation

9 years ago3.89.5
Matthias Clasen [Mon, 13 Mar 2017 23:52:06 +0000 (19:52 -0400)]
3.89.5

9 years agoAdd Friulian translation
Fabio Tomat [Mon, 13 Mar 2017 21:47:38 +0000 (21:47 +0000)]
Add Friulian translation

9 years agomir: start handling resize events again
William Hua [Mon, 13 Mar 2017 14:48:43 +0000 (10:48 -0400)]
mir: start handling resize events again

9 years agofilechooserwidget: Remvoe useless gtk_widget_show call
Timm Bäder [Mon, 13 Mar 2017 11:45:38 +0000 (12:45 +0100)]
filechooserwidget: Remvoe useless gtk_widget_show call

And a comment above. Even if it is not correct, it doesn't matter since
we call gtk_widget_show on it again later in that function.

9 years agomodelmenuitem: Remove unnecessary gtk_widget_show calls
Timm Bäder [Mon, 13 Mar 2017 11:14:38 +0000 (12:14 +0100)]
modelmenuitem: Remove unnecessary gtk_widget_show calls

9 years agolistbox: Avoid a gtk_widget_destroy call
Timm Bäder [Mon, 13 Mar 2017 11:06:53 +0000 (12:06 +0100)]
listbox: Avoid a gtk_widget_destroy call

9 years agofilechooserwidget: Avoid a gtk_widget_destroy
Timm Bäder [Tue, 7 Mar 2017 17:11:26 +0000 (18:11 +0100)]
filechooserwidget: Avoid a gtk_widget_destroy

9 years agofilechooserwidget: Remove unnecessary gtk_widget_show calls
Timm Bäder [Tue, 7 Mar 2017 16:37:35 +0000 (17:37 +0100)]
filechooserwidget: Remove unnecessary gtk_widget_show calls

9 years agoentry: make sure priv->current_pos is valid
Timm Bäder [Mon, 6 Mar 2017 17:41:12 +0000 (18:41 +0100)]
entry: make sure priv->current_pos is valid

We can e.g. get the entry dispose()d and a focus_out event after that
(because the toplevel unsets the focus which previously was the entry).
We then later use priv->current_pos in a call to pango API which makes
sure the given index is valid for the given layout. Since we lazily
create a GtkEntryBuffer in get_buffer() and a PangoLayout lazily in
gtk_entry_create_layout, these 2 are always valid but don't match
priv->current_pos in this situation.

Fix this by resetting priv->current-pos in dispose().

9 years agoentry: Remove cursor type parameter from get_cursor_locations
Timm Bäder [Mon, 6 Mar 2017 16:52:46 +0000 (17:52 +0100)]
entry: Remove cursor type parameter from get_cursor_locations

We are only ever passing CURSOR_STANDARD anyway.

9 years agomir: remove unused generate_configure_event ()
William Hua [Mon, 13 Mar 2017 08:07:37 +0000 (04:07 -0400)]
mir: remove unused generate_configure_event ()